From: H Hartley Sweeten Date: Wed, 23 Jan 2013 19:44:40 +0000 (-0700) Subject: staging: comedi: addi_apci_3501: introduce apci3501_wait_for_dac() X-Git-Tag: v3.9-rc1~127^2~288 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5458f3e7b5a8707a49948857d69b2eb2fa5931ac;p=pandora-kernel.git staging: comedi: addi_apci_3501: introduce apci3501_wait_for_dac() Refactor the code that waits for the DAC to be ready into a helper function. A timeout of some sort should be added to this helper so code the users to expect the error condition. In i_APCI3501_WriteAnalogOutput() just return the error and don't actually write the new value to the DAC. In apci3501_reset() output a dev_warn() that the DAC was not ready. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed