From: Pavel Emelyanov Date: Fri, 14 Nov 2008 22:51:45 +0000 (-0800) Subject: scm: fix scm_fp_list->list initialization made in wrong place X-Git-Tag: v2.6.28-rc6~62^2~16 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5421ae0153b4ba0469967cfd8de96144e3bf3979;p=pandora-kernel.git scm: fix scm_fp_list->list initialization made in wrong place This is the next page of the scm recursion story (the commit f8d570a4 net: Fix recursive descent in __scm_destroy()). In function scm_fp_dup(), the INIT_LIST_HEAD(&fpl->list) of newly created fpl is done *before* the subsequent memcpy from the old structure and thus the freshly initialized list is overwritten. But that's OK, since this initialization is not required at all, since the fpl->list is list_add-ed at the destruction time in any case (and is unused in other code), so I propose to drop both initializations, rather than moving it after the memcpy. Please, correct me if I miss something significant. Signed-off-by: Pavel Emelyanov Signed-off-by: David S. Miller --- Reading git-diff-tree failed