From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: Wed, 12 Nov 2014 09:28:33 +0000 (+0100)
Subject: tty: serial: 8250: omap: line is unsigned, don't check < 0
X-Git-Tag: omap-for-v3.20/drop-legacy-3517~83^2~24
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=54178fe6b3443249ec2dcd6eec9f2c3ebcdc3142;p=pandora-kernel.git

tty: serial: 8250: omap: line is unsigned, don't check < 0

Dan Carpenter reported:
|drivers/tty/serial/8250/8250_omap.c:1025 omap8250_probe()
|warn: unsigned 'up.port.line' is never less than zero.
|1025          if (up.port.line < 0) {

I (wrongly) assumed that line is an int and compiler didn't complain nor
did sparse. Since of_alias_get_id() and pdev->id can get negative I
check for the error via ret variable.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

Reading git-diff-tree failed