From: Stefan Eichenberger <eichest@gmail.com>
Date: Mon, 10 Jan 2022 17:48:31 +0000 (+0100)
Subject: tools/fitimage: remove redundant format check
X-Git-Tag: v2022.04-rc1~13^2~8
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5390cafed8858c8f9096131f2c2ddb2698931d2d;p=pandora-u-boot.git

tools/fitimage: remove redundant format check

fit_extract_contents does a fit_check_format even thought it was already
checked during imagetool_verify_print_header.
Therefore, this check is not necessary. This commit removes the
redundancy.

Signed-off-by: Stefan Eichenberger <eichest@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---

diff --git a/tools/fit_image.c b/tools/fit_image.c
index f4f372ba62f..62e1796ce5b 100644
--- a/tools/fit_image.c
+++ b/tools/fit_image.c
@@ -884,11 +884,6 @@ static int fit_extract_contents(void *ptr, struct image_tool_params *params)
 	/* Indent string is defined in header image.h */
 	p = IMAGE_INDENT_STRING;
 
-	if (fit_check_format(fit, IMAGE_SIZE_INVAL)) {
-		printf("Bad FIT image format\n");
-		return -1;
-	}
-
 	/* Find images parent node offset */
 	images_noffset = fdt_path_offset(fit, FIT_IMAGES_PATH);
 	if (images_noffset < 0) {