From: Jiri Slaby Date: Mon, 1 Nov 2010 15:08:55 +0000 (+0100) Subject: FS: cifs, remove unneeded NULL tests X-Git-Tag: v2.6.37-rc2~87^2~9 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=50ae28f0144a790fc63a5b89b9aca3ffa9f88522;p=pandora-kernel.git FS: cifs, remove unneeded NULL tests Stanse found that pSMBFile in cifs_ioctl and file->f_path.dentry in cifs_user_write are dereferenced prior their test to NULL. The alternative is not to dereference them before the tests. The patch is to point out the problem, you have to decide. While at it we cache the inode in cifs_user_write to a local variable and use all over the function. Signed-off-by: Jiri Slaby Cc: Steve French Cc: linux-cifs@vger.kernel.org Cc: Jeff Layton Cc: Christoph Hellwig Signed-off-by: Steve French --- Reading git-diff-tree failed