From: Theodore Ts'o <tytso@mit.edu>
Date: Mon, 23 Nov 2009 12:17:34 +0000 (-0500)
Subject: ext4: make sure directory and symlink blocks are revoked
X-Git-Tag: v2.6.33-rc1~330^2~36
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=50689696867d95b38d9c7be640a311494a04fb86;p=pandora-kernel.git

ext4: make sure directory and symlink blocks are revoked

When an inode gets unlinked, the functions ext4_clear_blocks() and
ext4_remove_blocks() call ext4_forget() for all the buffer heads
corresponding to the deleted inode's data blocks.  If the inode is a
directory or a symlink, the is_metadata parameter must be non-zero so
ext4_forget() will revoke them via jbd2_journal_revoke().  Otherwise,
if these blocks are reused for a data file, and the system crashes
before a journal checkpoint, the journal replay could end up
corrupting these data blocks.

Thanks to Curt Wohlgemuth for pointing out potential problems in this
area.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@kernel.org
---

Reading git-diff-tree failed