From: Grant Likely Date: Fri, 25 Jan 2008 05:25:31 +0000 (-0700) Subject: [POWERPC] mpc52xx_psc_spi device driver must not touch port_config and cdm X-Git-Tag: v2.6.25-rc1~1131^2~9^2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4fb4c5582475452d3bf7c5072ef2d15ee06f7723;p=pandora-kernel.git [POWERPC] mpc52xx_psc_spi device driver must not touch port_config and cdm It is dangerous for an mpc52xx device driver to modify the port_config register. If the driver is probed incorrectly, it will change the pin IO configuration in ways which may not be compatible with the board. port_config should be set up by the bootloader, or failing that, in the platform setup code in arch/powerpc/platforms/52xx. Also, modifying CDM registers directly can cause a race condition with other drivers. Instead call a common routine to modify CDM settings. Signed-off-by: Grant Likely Acked-by: Dragos Carp --- Reading git-diff-tree failed