From: Ben Hutchings Date: Fri, 16 Jan 2015 17:51:25 +0000 (+0000) Subject: sh_eth: Fix ethtool operation crash when net device is down X-Git-Tag: fixes-v4.0-rc1~271^2~3^2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4f9dce230b32eec45cec8c28cae61efdfa2f7d57;p=pandora-kernel.git sh_eth: Fix ethtool operation crash when net device is down The driver connects and disconnects the PHY device whenever the net device is brought up and down. The ethtool get_settings, set_settings and nway_reset operations will dereference a null or dangling pointer if called while it is down. I think it would be preferable to keep the PHY connected, but there may be good reasons not to. As an immediate fix for this bug: - Set the phydev pointer to NULL after disconnecting the PHY - Change those three operations to return -ENODEV while the PHY is not connected Signed-off-by: Ben Hutchings Signed-off-by: David S. Miller --- Reading git-diff-tree failed