From: Axel Lin <axel.lin@gmail.com>
Date: Tue, 9 Nov 2010 08:41:48 +0000 (+0000)
Subject: hwmon: (gpio-fan) Fix fan_ctrl_init error path
X-Git-Tag: v2.6.37-rc2~29^2
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4f5b7994f0610fefff0782227ab71469ece54a5b;p=pandora-kernel.git

hwmon: (gpio-fan) Fix fan_ctrl_init error path

In current implementation, the sysfs entries is not removed before return -ENODEV.

Creating the sysfs attribute should be the last thing done by the function,
after all the rest has been successful.
Otherwise there is a small window during which user-space can access the attribute
but the driver isn't ready to deal with the requests.

Fix it by moving sysfs_create_group to be the last thing done by the function.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Simon Guinot <sguinot@lacie.com>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
---

Reading git-diff-tree failed