From: Alexey Kuznetsov Date: Tue, 17 Nov 2009 22:10:11 +0000 (-0800) Subject: [SCSI] fix crash when disconnecting usb storage X-Git-Tag: v2.6.32~31^2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4e46bf89972b9d98a9f282a9fed2359756a5e34e;p=pandora-kernel.git [SCSI] fix crash when disconnecting usb storage __scsi_remove_device() in scsi_forget_host() is executed out of scan_mutex and races with scsi_destroy_sdev() <- scsi_sysfs_add_devices() <- scsi_finish_async_scan(). The result is use after free and/or double free, oops. The fix is simple, move scsi_forget_host() under scan_mutex. scsi_forget_host() is just sequence of __scsi_remove_device(). All another calls of __scsi_remove_device() are made under scan_mutex. So that it is safe. Signed-off-by: Alexey Kuznetsov Signed-off-by: Denis V. Lunev Signed-off-by: Andrew Morton Signed-off-by: James Bottomley --- Reading git-diff-tree failed