From: Patrick McHardy <kaber@trash.net>
Date: Mon, 22 Jun 2009 12:17:12 +0000 (+0200)
Subject: netfilter: xt_rateest: fix comparison with self
X-Git-Tag: v2.6.31-rc1~14^2~10
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4d900f9df5f0569c2dc536701e2c11b6d50ebebf;p=pandora-kernel.git

netfilter: xt_rateest: fix comparison with self

As noticed by Török Edwin <edwintorok@gmail.com>:

Compiling the kernel with clang has shown this warning:

net/netfilter/xt_rateest.c:69:16: warning: self-comparison always results in a
constant value
                        ret &= pps2 == pps2;
                                    ^
Looking at the code:
if (info->flags & XT_RATEEST_MATCH_BPS)
            ret &= bps1 == bps2;
        if (info->flags & XT_RATEEST_MATCH_PPS)
            ret &= pps2 == pps2;

Judging from the MATCH_BPS case it seems to be a typo, with the intention of
comparing pps1 with pps2.

http://bugzilla.kernel.org/show_bug.cgi?id=13535

Signed-off-by: Patrick McHardy <kaber@trash.net>
---

Reading git-diff-tree failed