From: Eldad Zack <eldad@fogrefinery.com>
Date: Mon, 29 Apr 2013 19:15:46 +0000 (+0200)
Subject: ALSA: usb-audio: caiaq: fix endianness bug in snd_usb_caiaq_maschine_dispatch
X-Git-Tag: omap-for-v3.10/dt-fixes-for-merge-window~52^2
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4ca231b2e6ed171107c5b21f9e92d1965fd6fd9e;p=pandora-kernel.git

ALSA: usb-audio: caiaq: fix endianness bug in snd_usb_caiaq_maschine_dispatch

Current code does this:

  be16_to_cpu(buf[i * 2] << 8 | buf[(i * 2) + 1])

Which is effectively (neglecting the index):

  be16_to_cpu(be16_to_cpu(*((u16 *) buf)))

This means the int16 in the buffer is not converted at all.

Daniel Mack confirmed that the driver works on little endian
CPUs, leading to the conclusion that the device-side structure
is actually little endian.
This changes the code to use le16_to_cpu().

Caught by sparse.

Acked-by: Daniel Mack <zonque@gmail.com>
Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

Reading git-diff-tree failed