From: Julia Lawall Date: Tue, 29 Jun 2010 04:42:53 +0000 (-0300) Subject: V4L/DVB: drivers/media/video/pvrusb2: Add missing mutex_unlock X-Git-Tag: v2.6.36-rc1~582^2~150 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4c61f678a468768afd45c3d9ac697f8f55aa04eb;p=pandora-kernel.git V4L/DVB: drivers/media/video/pvrusb2: Add missing mutex_unlock Add a mutex_unlock missing on the error path. In the other functions in the same file the locks and unlocks of this mutex appear to be balanced, so it would seem that the same should hold in this case. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression E1; @@ * mutex_lock(E1,...); <+... when != E1 if (...) { ... when != E1 * return ...; } ...+> * mutex_unlock(E1,...); // Signed-off-by: Julia Lawall Signed-off-by: Douglas Schilling Landgraf Signed-off-by: Mauro Carvalho Chehab --- Reading git-diff-tree failed