From: H Hartley Sweeten Date: Mon, 20 May 2013 21:29:39 +0000 (-0700) Subject: staging: comedi: usbdux: consolidate the firmware upload X-Git-Tag: omap-for-v3.11/fixes-for-merge-window~76^2~531 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4bf6bfe3c8ae4d41c2bb3784981ba069c80ef55e;p=pandora-kernel.git staging: comedi: usbdux: consolidate the firmware upload Absorb the usbdux_stop(), usbdux_upload(), and usbdux_start() functions into firmware_upload(). Each of them just do a usb_control_msg() to the device and output an error message if it fails. A similar message is also output by firmware_upload() so the extra messages are redundant. We can also share the malloc'ed local buffer needed for the usb_control_msg(). Signed-off-by: H Hartley Sweeten Cc Ian Abbott Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed