From: Florian Fainelli Date: Mon, 22 Sep 2014 18:54:43 +0000 (-0700) Subject: net: bcmgenet: call bcmgenet_dma_teardown in bcmgenet_fini_dma X-Git-Tag: fixes-for-v3.18-merge-window~87^2^2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4a0c081eff43a11c65dee3ad6c457f7f58bcebe0;p=pandora-kernel.git net: bcmgenet: call bcmgenet_dma_teardown in bcmgenet_fini_dma We should not be manipulaging the DMA_CTRL registers directly by writing 0 to them to disable DMA. This is an operation that needs to be timed to make sure the DMA engines have been properly stopped since their state machine stops on a packet boundary, not immediately. Make sure that tha bcmgenet_fini_dma() calls bcmgenet_dma_teardown() to ensure a proper DMA engine state. As a result, we need to reorder the function bodies to resolve the use dependency. Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") Signed-off-by: Florian Fainelli Signed-off-by: David S. Miller --- Reading git-diff-tree failed