From: David Herrmann Date: Wed, 2 Oct 2013 14:58:38 +0000 (+0200) Subject: simplefb: fix unmapping fb during destruction X-Git-Tag: v3.13-rc1~93^2~8 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=498f6d3660e8c3343b26a5f8e2707b642bcf3fc8;p=pandora-kernel.git simplefb: fix unmapping fb during destruction Unfortunately, fbdev does not create its own "struct device" for framebuffers. Instead, it attaches to the device of the parent layer. This has the side-effect that devm_* managed resources are not cleaned up on framebuffer-destruction but rather during destruction of the parent-device. In case of fbdev this might be too late, though. remove_conflicting_framebuffer() may remove fbdev devices but keep the parent device as it is. Therefore, we now use plain ioremap() and unmap the framebuffer in the fb_destroy() callback. Note that we must not free the device here as this might race with the parent-device removal. Instead, we rely on unregister_framebuffer() as barrier and we're safe. Reported-by: Tom Gundersen Signed-off-by: David Herrmann Acked-by: Stephen Warren Signed-off-by: Tomi Valkeinen --- Reading git-diff-tree failed