From: John Fastabend Date: Mon, 21 Oct 2013 21:28:02 +0000 (-0700) Subject: macvlan: resolve ENOENT errors on creation X-Git-Tag: v3.13-rc1~105^2~139 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=47d4ab91e4472723f181075c81627374ca86816c;p=pandora-kernel.git macvlan: resolve ENOENT errors on creation After the commit below attempting to create macvlan devices was resulting in ENOENT errors, # ip link add link p3p2 type macvlan RTNETLINK answers: Invalid argument This happens because netdev_upper_dev_link() is called before register_netdevice() in the macvlan code. Through a call chain this results in a call to __netdev_adjacent_dev_insert() and finally a sysfs_create_link(). This requires the kobject of the macvlan to be registered which is done in register_netdevice(). If there is no kobject which is the case here the ENOENT error is seen on the command line. To resolve this move the netdev_upper_dev_link() call below the register_netdevice() call. This aligns with vlan driver flow. Regression introduced here, commit 5831d66e8097aedfa3bc35941cf265ada2352317 Author: Veaceslav Falico Date: Wed Sep 25 09:20:32 2013 +0200 net: create sysfs symlinks for neighbour devices CC: Veaceslav Falico CC: Neil Horman Signed-off-by: John Fastabend Acked-by: Veaceslav Falico Acked-by: Neil Horman Signed-off-by: David S. Miller --- Reading git-diff-tree failed