From: Tomi Valkeinen Date: Thu, 23 Feb 2012 10:21:09 +0000 (+0200) Subject: OMAPDSS: APPLY: print warning if wait_pending_extra_info_updates fails X-Git-Tag: v3.4-rc1~125^2~8^2~2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=4614679c9d3b77e87b390b6afe8a8dfc980f4387;p=pandora-kernel.git OMAPDSS: APPLY: print warning if wait_pending_extra_info_updates fails wait_pending_extra_info_updates() currently does a hacky second check for extra_info_update_ongoing() at the end of the function to show a warning if extra_info update is still ongoing. The call to extra_info_update_ongoing() should really be inside spinlock, but that's a bit heavy just for verification. Rather than that, check the return value of the wait_for_completion_timeout() and print an error if it has timeouted or returned an error. Even better would be to return the error value and act on it in the callers of wait_pending_extra_info_updates. However, it's not clear what the callers should do in case of an error, as the error should only happen if there's a bug in the driver or the HW. So we'll just print the warning for now. Signed-off-by: Tomi Valkeinen --- Reading git-diff-tree failed