From: Michael Holzheu Date: Thu, 17 Dec 2015 18:06:02 +0000 (+0100) Subject: s390/dis: Fix handling of format specifiers X-Git-Tag: v3.2.76~52 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=45f32e359d36dd045e4af0d1bea8bbbafd81eeb7;p=pandora-kernel.git s390/dis: Fix handling of format specifiers commit 272fa59ccb4fc802af28b1d699c2463db6a71bf7 upstream. The print_insn() function returns strings like "lghi %r1,0". To escape the '%' character in sprintf() a second '%' is used. For example "lghi %%r1,0" is converted into "lghi %r1,0". After print_insn() the output string is passed to printk(). Because format specifiers like "%r" or "%f" are ignored by printk() this works by chance most of the time. But for instructions with control registers like "lctl %c6,%c6,780" this fails because printk() interprets "%c" as character format specifier. Fix this problem and escape the '%' characters twice. For example "lctl %%%%c6,%%%%c6,780" is then converted by sprintf() into "lctl %%c6,%%c6,780" and by printk() into "lctl %c6,%c6,780". Signed-off-by: Michael Holzheu Signed-off-by: Martin Schwidefsky [bwh: Backported to 3.2: drop the OPERAND_VR case] Signed-off-by: Ben Hutchings --- Reading git-diff-tree failed