From: Eric Sesterhenn Date: Mon, 25 Sep 2006 23:59:08 +0000 (-0700) Subject: [SCSI] Signdness issue in drivers/scsi/osst.c X-Git-Tag: v2.6.19-rc1~4^2~39 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=45223fd77c2b39d05dd7f1aaabf614abb1770bbe;p=pandora-kernel.git [SCSI] Signdness issue in drivers/scsi/osst.c another signdness warning from gcc 4.1 drivers/scsi/osst.c:5154: warning: comparison of unsigned expression < 0 is always false The problem is that blk is defined as unsigned, but all usages of it are normal int cases. osst_get_frame_position() and osst_get_sector() return ints and can return negative values. If blk stays an unsigned int, the error check is useless. Signed-off-by: Eric Sesterhenn Signed-off-by: Andrew Morton Signed-off-by: James Bottomley --- Reading git-diff-tree failed