From: Olof Johansson Date: Mon, 9 Sep 2013 17:34:23 +0000 (-0700) Subject: direct-io: Use return from cmpxchg to decide of assignment happened X-Git-Tag: v3.12-rc1~81 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=45150c43b1b0c16e665fd0a5cdcca128b8192db1;p=pandora-kernel.git direct-io: Use return from cmpxchg to decide of assignment happened Not using the return value can in the generic case be racy, so it's in general good practice to check the return value instead. This also resolved the warning caused on ARM and other architectures: fs/direct-io.c: In function 'sb_init_dio_done_wq': fs/direct-io.c:557:2: warning: value computed is not used [-Wunused-value] Signed-off-by: Olof Johansson Reviewed-by: Jan Kara Cc: Geert Uytterhoeven Cc: Stephen Rothwell Cc: Al Viro Cc: Christoph Hellwig Cc: Russell King Cc: H Peter Anvin Signed-off-by: Linus Torvalds --- Reading git-diff-tree failed