From: Jerome Forissier <jerome.forissier@linaro.org>
Date: Fri, 14 Mar 2025 08:44:10 +0000 (+0100)
Subject: net: lwip: do_ping() should return CMD_RET_FAILURE when no device
X-Git-Tag: v2025.04~9^2~3
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=42df30a210c07c020b96a1d13d066125bd5f0ffd;p=pandora-u-boot.git

net: lwip: do_ping() should return CMD_RET_FAILURE when no device

do_ping() expects ping_loop() to return a negative value on error, so
that it can propagate it to the caller as CMD_RET_FAILURE. This is not
the case when no ethernet device is found, so fix that.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---

diff --git a/net/lwip/ping.c b/net/lwip/ping.c
index 200a702bbb5..c586a96806d 100644
--- a/net/lwip/ping.c
+++ b/net/lwip/ping.c
@@ -121,7 +121,7 @@ static int ping_loop(struct udevice *udev, const ip_addr_t *addr)
 
 	netif = net_lwip_new_netif(udev);
 	if (!netif)
-		return CMD_RET_FAILURE;
+		return -ENODEV;
 
 	printf("Using %s device\n", udev->name);