From: Julia Lawall <julia.lawall@lip6.fr>
Date: Thu, 21 Aug 2014 12:06:06 +0000 (-0500)
Subject: mfd: menelaus: Fix error return code
X-Git-Tag: fixes-against-v3.18-rc2~69^2~59
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=42a71ef97b7ac31ae8f929c36048fec5cd201a49;p=pandora-kernel.git

mfd: menelaus: Fix error return code

Convert a zero return value on error to a negative one, as returned
elsewhere in the function.

Additionally, converted 1 << 7 to BIT(7) at the suggestion of Lee Jones.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---

Reading git-diff-tree failed