From: Vesa-Matti Kari Date: Wed, 6 Aug 2008 15:24:51 +0000 (+0300) Subject: selinux: conditional expression type validation was off-by-one X-Git-Tag: v2.6.28-rc1~724^2^2~12 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=421fae06be9e0dac45747494756b3580643815f9;p=pandora-kernel.git selinux: conditional expression type validation was off-by-one expr_isvalid() in conditional.c was off-by-one and allowed invalid expression type COND_LAST. However, it is this header file that needs to be fixed. That way the if-statement's disjunction's second component reads more naturally, "if expr type is greater than the last allowed value" ( rather than using ">=" in conditional.c): if (expr->expr_type <= 0 || expr->expr_type > COND_LAST) Signed-off-by: Vesa-Matti Kari Signed-off-by: James Morris --- Reading git-diff-tree failed