From: Jesper Juhl Date: Fri, 23 Mar 2012 00:08:34 +0000 (+0100) Subject: drivers/platform/x86/amilo-rfkill.c::amilo_rfkill_probe() avoid NULL deref X-Git-Tag: v3.4-rc1~63^2~1 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=41603e9783a24c8c7cce548c0819bdc9e46a585b;p=pandora-kernel.git drivers/platform/x86/amilo-rfkill.c::amilo_rfkill_probe() avoid NULL deref In drivers/platform/x86/amilo-rfkill.c::amilo_rfkill_probe() the call to dmi_first_match() may fail and return NULL. If it does return NULL, then we'll be dereferencing a NULL pointer in the rfkill_alloc() call where we do 'system_id->driver_data' --> KABOOM! Avoid that problem by testing for a NULL return value from dmi_first_match() and bailing out if it fails. I was a bit uncertain about what to return in the failure case. In the end I settled for -ENXIO as the most logical error to return. Signed-off-by: Jesper Juhl Signed-off-by: Matthew Garrett --- Reading git-diff-tree failed