From: Ian Abbott Date: Wed, 3 Oct 2012 15:25:17 +0000 (+0100) Subject: staging: comedi: amplc_pc236: fix invalid register access during detach X-Git-Tag: v3.2.33~83 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=414f1c99192dafc1d09e0188c1481ef722fe05d6;p=pandora-kernel.git staging: comedi: amplc_pc236: fix invalid register access during detach commit aaeb61a97b7159ebe30b18a422d04eeabfa8790b upstream. `pc236_detach()` is called by the comedi core if it attempted to attach a device and failed. `pc236_detach()` calls `pc236_intr_disable()` if the comedi device private data pointer (`devpriv`) is non-null. This test is insufficient as `pc236_intr_disable()` accesses hardware registers and the attach routine may have failed before it has saved their I/O base addresses. Fix it by checking `dev->iobase` is non-zero before calling `pc236_intr_disable()` as that means the I/O base addresses have been saved and the hardware registers can be accessed. It also implies the comedi device private data pointer is valid, so there is no need to check it. Signed-off-by: Ian Abbott [Ian Abbott: This patch is for the stable 3.0 kernel.] Signed-off-by: Ben Hutchings --- Reading git-diff-tree failed