From: Geert Uytterhoeven Date: Fri, 8 May 2015 08:47:43 +0000 (+0200) Subject: PM / clk: Fix clock error check in __pm_clk_add() X-Git-Tag: omap-for-v4.2/fixes-rc1^2~154^2~4^2~1 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3fc3a0be0dab352e065d1dad7d3f81953ed0d4bc;p=pandora-kernel.git PM / clk: Fix clock error check in __pm_clk_add() In the final iteration of commit 245bd6f6af8a62a2 ("PM / clock_ops: Add pm_clk_add_clk()"), a refcount increment was added by Grygorii Strashko. However, the accompanying IS_ERR() check operates on the wrong clock pointer, which is always zero at this point, i.e. not an error. This may lead to a NULL pointer dereference later, when __clk_get() tries to dereference an error pointer. Check the passed clock pointer instead to fix this. Signed-off-by: Geert Uytterhoeven Fixes: 245bd6f6af8a62a2 ("PM / clock_ops: Add pm_clk_add_clk()") Signed-off-by: Rafael J. Wysocki --- Reading git-diff-tree failed