From: Geert Uytterhoeven Date: Wed, 6 Aug 2014 12:59:03 +0000 (+0200) Subject: spi: sh-msiof: Fix leaking of unused DMA descriptors X-Git-Tag: fix-v3.17-io-chain-v3~6^2^2~1 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3e81b59208fa4697c6c3b6eefb92892b47f8b1e7;p=pandora-kernel.git spi: sh-msiof: Fix leaking of unused DMA descriptors If dmaengine_prep_slave_sg() or dmaengine_submit() fail, we may leak unused DMA descriptors. As per Documentation/dmaengine.txt, once a DMA descriptor has been obtained, it must be submitted. Hence: - First prepare and submit all DMA descriptors, - Prepare the SPI controller for DMA, - Start DMA by calling dma_async_issue_pending(), - Make sure to call dmaengine_terminate_all() on all descriptors that haven't completed. Reported-by: Laurent Pinchart Signed-off-by: Geert Uytterhoeven Signed-off-by: Mark Brown --- Reading git-diff-tree failed