From: Dan Carpenter <error27@gmail.com>
Date: Tue, 1 Jun 2010 07:14:04 +0000 (+0200)
Subject: smack: opt_dentry is never null in in smack_d_instantiate()
X-Git-Tag: v2.6.36-rc1~584^2~82
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3e62cbb8436f6c0cb799c8b7f106de7f662a7b8d;p=pandora-kernel.git

smack: opt_dentry is never null in in smack_d_instantiate()

This patch removes some unneeded code for if opt_dentry is null because
that can never happen.

The function dereferences "opt_dentry" earlier when it checks
"if (opt_dentry->d_parent == opt_dentry) {".  That code was added in
2008.

This function called from security_d_instantiate().  I checked all the
places which call security_d_instantiate() and dentry is always non-null.
I also checked the selinux version of this hook and there is a comment
which says that dentry should be non-null if called from
d_instantiate().

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Casey Schaufler <casey@schaufler-ca.com>
Signed-off-by: James Morris <jmorris@namei.org>
---

Reading git-diff-tree failed