From: Dan Williams Date: Mon, 28 Nov 2011 20:08:22 +0000 (-0800) Subject: [SCSI] libsas: close error handling vs sas_ata_task_done() race X-Git-Tag: v3.4-rc1~145^2~58 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3dff5721e4f67e6231dfc419d30aaa7563bfffd4;p=pandora-kernel.git [SCSI] libsas: close error handling vs sas_ata_task_done() race Since sas_ata does not implement ->freeze(), completions for scmds and internal commands can still arrive concurrent with ata_scsi_cmd_error_handler() and sas_ata_post_internal() respectively. By the time either of those is called libata has committed to completing the qc, and the ATA_PFLAG_FROZEN flag tells sas_ata_task_done() it has lost the race. In the sas_ata_post_internal() case we take on the additional responsibility of freeing the sas_task to close the race with sas_ata_task_done() freeing the the task while sas_ata_post_internal() is in the process of invoking ->lldd_abort_task(). Signed-off-by: Dan Williams Signed-off-by: James Bottomley --- Reading git-diff-tree failed