From: Julia Lawall Date: Sun, 12 Jul 2009 20:05:03 +0000 (+0200) Subject: drivers/isdn: Drop unnecessary NULL test X-Git-Tag: v2.6.32-rc1~703^2~545^2~2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3cad3da3ed9ece03704f7d67e038b8ae710fa312;p=pandora-kernel.git drivers/isdn: Drop unnecessary NULL test The result of container_of should not be NULL. In particular, in this case the argument to the enclosing function has passed though INIT_WORK, which dereferences it, implying that its container cannot be NULL. A simplified version of the semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @@ identifier fn,work,x,fld; type T; expression E1,E2; statement S; @@ static fn(struct work_struct *work) { ... when != work = E1 x = container_of(work,T,fld) ... when != x = E2 - if (x == NULL) S ... } // Signed-off-by: Julia Lawall Signed-off-by: Karsten Keil --- Reading git-diff-tree failed