From: Sebastian Andrzej Siewior Date: Wed, 12 Nov 2014 09:28:34 +0000 (+0100) Subject: tty: serial: omap_serial: line is unsigned, don't check < 0 X-Git-Tag: omap-for-v3.19/fixes-rc1~86^2~23 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3c59958d5868f77741930402dfcb27e9dc8968d2;p=pandora-kernel.git tty: serial: omap_serial: line is unsigned, don't check < 0 Dan Carpenter reported: |drivers/tty/serial/8250/8250_omap.c:1025 omap8250_probe() |warn: unsigned 'up.port.line' is never less than zero. |1025 if (up.port.line < 0) { Since of_alias_get_id() and pdev->id can get negative I check for the error via ret variable. Reported-by: Dan Carpenter Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed