From: Sebastian Andrzej Siewior Date: Thu, 6 Sep 2012 18:11:19 +0000 (+0200) Subject: usb: gadget: move usb_gadget_controller_number() into a .c file and libcomposite X-Git-Tag: omap-for-v3.7-rc1/fixes-cpufreq-signed~73^2~141^2~14 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3b4a3fc0ba83265c0bfcfdfc3416e65e47441747;p=pandora-kernel.git usb: gadget: move usb_gadget_controller_number() into a .c file and libcomposite After I moved the function from the header file to the c file I see: | $ size drivers/usb/gadget/gadget_chips.o | text data bss dec hex filename | 1048 0 0 1048 418 drivers/usb/gadget/gadget_chips.o That is almost a KiB which is removed from each user. As Felipe pointed out, the function / usage is very dumb actually. This is used for the following reasons: - epautoconf ep hint (could provide a per-gadget callback) - miss-features. currently the missing altsetting on pxa's and something ZLP related on musbhdrc (looks like an optimisation which could be implemented in musb itself if it is correct) - unique BCD accross all UDCs. Not sure how important this is. Acked-by: Michal Nazarewicz Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Felipe Balbi --- Reading git-diff-tree failed