From: David S. Miller Date: Wed, 16 Feb 2011 22:56:22 +0000 (-0800) Subject: ipv4: Avoid use of signed integers in fib_trie code. X-Git-Tag: v2.6.39-rc1~468^2~330 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3b004569d86d02786ebae496e75dc0b625be3e9a;p=pandora-kernel.git ipv4: Avoid use of signed integers in fib_trie code. GCC emits all kinds of crazy zero extensions when we go from signed int, to unsigned short, etc. etc. This transformation has to be legal because: 1) In tkey_extract_bits() in mask_pfx(), the values are used to perform shifts, on which negative values are undefined by C. 2) In fib_table_lookup() we perform comparisons with unsigned values, constants, and additions. None of which should encounter negative values. Signed-off-by: David S. Miller --- Reading git-diff-tree failed