From: Kyle Moffett Date: Thu, 22 Dec 2011 10:19:09 +0000 (+0000) Subject: powerpc/mpic: Fix use of "flags" variable in mpic_alloc() X-Git-Tag: v3.4-rc1~159^2~70 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3a7a7176e840f448aae929f7761ea80cf892c665;p=pandora-kernel.git powerpc/mpic: Fix use of "flags" variable in mpic_alloc() The mpic_alloc() function takes a "flags" parameter and assigns it into the mpic->flags variable fairly early on, but several later pieces of code detect various device-tree properties and save them into the "mpic->flags" variable (EG: "big-endian" => MPIC_BIG_ENDIAN). Unfortunately, a number of codepaths (including several which test the flag MPIC_BIG_ENDIAN!) test "flags" instead of "mpic->flags", and get wrong answers as a result. Consolidate the device-tree flag tests early in mpic_alloc() and change all of the checks after "mpic->flags" is init'ed to use "mpic->flags". [BenH: Fixed up use of mpic->node before it's initialized] Signed-off-by: Kyle Moffett Signed-off-by: Benjamin Herrenschmidt --- Reading git-diff-tree failed