From: Hans Verkuil Date: Mon, 8 Dec 2014 16:23:50 +0000 (-0300) Subject: [media] cx88: remove leftover start_video_dma() call X-Git-Tag: omap-for-v3.19/fixes-rc1~36^2~4 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=389208e1173e097590856ed24a505551510f78d4;p=pandora-kernel.git [media] cx88: remove leftover start_video_dma() call The start_streaming op is responsible for starting the video dma, so it shouldn't be called anymore from the buf_queue op. Unfortunately, this call to start_video_dma() was added to the start_streaming op, but was forgotten to be removed from the buf_queue op, which is where it used to be before the vb2 conversion. Calling this function twice causes very hard to find errors: sometimes it works, sometimes it doesn't. It took me a whole friggin' day to track this down, and in the end it was just luck that my eye suddenly triggered on that line. Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- Reading git-diff-tree failed