From: Ben Hutchings Date: Sun, 23 Aug 2009 15:59:04 +0000 (+0100) Subject: drm/r128: Add test for initialisation to all ioctls that require it X-Git-Tag: v2.6.27.46~17 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3807f5c31534736f3c23630b11bd4a259eaa46fd;p=pandora-kernel.git drm/r128: Add test for initialisation to all ioctls that require it commit 7dc482dfeeeefcfd000d4271c4626937406756d7 upstream. Almost all r128's private ioctls require that the CCE state has already been initialised. However, most do not test that this has been done, and will proceed to dereference a null pointer. This may result in a security vulnerability, since some ioctls are unprivileged. This adds a macro for the common initialisation test and changes all ioctl implementations that require prior initialisation to use that macro. Also, r128_do_init_cce() does not test that the CCE state has not been initialised already. Repeated initialisation may lead to a crash or resource leak. This adds that test. Signed-off-by: Ben Hutchings Signed-off-by: Dave Airlie Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed