From: Julia Lawall Date: Thu, 12 Jan 2012 09:55:15 +0000 (+0100) Subject: clocksource: cyclone: Add missing iounmap X-Git-Tag: v3.4-rc1~190^2~9^2~5 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=36f21f1ce419a552227b32d445e40c2d99286275;p=pandora-kernel.git clocksource: cyclone: Add missing iounmap Add missing iounmap in error handling code, in a case where the function already preforms iounmap on some other execution path. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; statement S,S1; int ret; @@ e = \(ioremap\|ioremap_nocache\)(...) ... when != iounmap(e) if (<+...e...+>) S ... when any when != iounmap(e) *if (...) { ... when != iounmap(e) return ...; } ... when any iounmap(e); // Signed-off-by: Julia Lawall [fixed up subject -jstultz] Signed-off-by: John Stultz --- Reading git-diff-tree failed