From: Dave Chinner <dchinner@redhat.com>
Date: Fri, 6 Jun 2014 06:02:12 +0000 (+1000)
Subject: xfs: kill xfs_buf_geterror()
X-Git-Tag: omap-for-v3.16/fixes-against-rc1~55^2^2~3
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=36de95567f910f5544060f50346d8677ae13ad22;p=pandora-kernel.git

xfs: kill xfs_buf_geterror()

Most of the callers are just calling ASSERT(!xfs_buf_geterror())
which means they are checking for bp->b_error == 0. If bp is null in
this case, we will assert fail, and hence it's no different in
result to oopsing because of a null bp. In some cases, errors have
already been checked for or the function returning the buffer can't
return a buffer with an error, so it's just a redundant assert.
Either way, the assert can either be removed.

The other two non-assert callers can just test for a buffer and
error properly.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
---

Reading git-diff-tree failed