From: Damien Lespiau Date: Wed, 11 Feb 2015 18:21:43 +0000 (+0000) Subject: drm/i915/skl: Fix always true comparison in a revision id check X-Git-Tag: omap-for-v4.2/o2_dc~72^2~35^2~3 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=35c8ce6ac5c2efedf76912c86b2021a6e4ec1655;p=pandora-kernel.git drm/i915/skl: Fix always true comparison in a revision id check It's always a good idea to keep static analysis happy (also because it prompts doing the check like I proposed :), this time smatch complains: drivers/gpu/drm/i915/intel_ringbuffer.c:891 gen9_init_workarounds() warn: always true condition '((->dev->pdev->revision) >= (0)) => (0-255 >= 0)' That's because revision is a u8. Tweak a bit the condition then. Cc: Nick Hoath Signed-off-by: Damien Lespiau Reviewed-by: Nick Hoath Signed-off-by: Daniel Vetter --- Reading git-diff-tree failed