From: Ben Hutchings <ben@decadent.org.uk>
Date: Mon, 14 Dec 2009 16:05:09 +0000 (+0000)
Subject: via-velocity: Give RX descriptors to the NIC later on open or MTU change
X-Git-Tag: v2.6.33-rc4~10^2~48
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=35bb5cadc8c7b1462df57e32e08d964f1be7a75c;p=pandora-kernel.git

via-velocity: Give RX descriptors to the NIC later on open or MTU change

velocity_open() calls velocity_give_many_rx_descs(), which gives RX
descriptors to the NIC, before installing an interrupt handler or
calling velocity_init_registers().  I think this is very unsafe and it
appears to explain the bug report <http://bugs.debian.org/508527>.

On MTU change, velocity_give_many_rx_descs() is again called before
velocity_init_registers().  I'm not sure whether this is unsafe but
it does look wrong.

Therefore, move the calls to velocity_give_many_rx_descs() after
request_irq() and velocity_init_registers().

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Tested-by: Jan Ceuleers <jan.ceuleers@computer.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

Reading git-diff-tree failed