From: Xi Wang <xi.wang@gmail.com>
Date: Tue, 14 Feb 2012 17:32:41 +0000 (-0300)
Subject: [media] lgdt330x: fix signedness error in i2c_read_demod_bytes()
X-Git-Tag: v3.4-rc1~110^2^2~138
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=34817174fca0c5512c2d5b6ea0fc37a0337ce1d8;p=pandora-kernel.git

[media] lgdt330x: fix signedness error in i2c_read_demod_bytes()

The error handling in lgdt3303_read_status() and lgdt330x_read_ucblocks()
doesn't work, because i2c_read_demod_bytes() returns a u8 and (err < 0)
is always false.

        err = i2c_read_demod_bytes(state, 0x58, buf, 1);
        if (err < 0)
                return err;

Change the return type of i2c_read_demod_bytes() to int.  Also change
the return value on error to -EIO to make (err < 0) work.

Signed-off-by: Xi Wang <xi.wang@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---

Reading git-diff-tree failed