From: Markus Elfring Date: Sun, 23 Nov 2014 16:05:18 +0000 (+0100) Subject: video: uvesafb: Deletion of an unnecessary check before the function call "platform_d... X-Git-Tag: omap-for-v3.20/drop-legacy-3517~125^2~1 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=34685627288baa370a6102ce58d47266d24050fd;p=pandora-kernel.git video: uvesafb: Deletion of an unnecessary check before the function call "platform_device_put" The platform_device_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Tomi Valkeinen --- diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c index f718627b368f..d32d1c4d1b99 100644 --- a/drivers/video/fbdev/uvesafb.c +++ b/drivers/video/fbdev/uvesafb.c @@ -1922,8 +1922,7 @@ static int uvesafb_init(void) err = -ENOMEM; if (err) { - if (uvesafb_device) - platform_device_put(uvesafb_device); + platform_device_put(uvesafb_device); platform_driver_unregister(&uvesafb_driver); cn_del_callback(&uvesafb_cn_id); return err;