From: Takashi Iwai Date: Thu, 14 Nov 2013 14:35:46 +0000 (+0100) Subject: ALSA: jack: Unregister input device at disconnection X-Git-Tag: v3.13-rc1~54^2~2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=32b8544296b944b204b33f9837701d4d0b9adefe;p=pandora-kernel.git ALSA: jack: Unregister input device at disconnection The recent change in sysfs triggered a kernel WARNING at unloading a sound driver like WARNING: CPU: 3 PID: 2247 at fs/sysfs/group.c:214 sysfs_remove_group+0xe8/0xf0() sysfs group ffffffff81ab7b20 not found for kobject 'event14' for each jack instance. It's because the unregistration of jack input device is done in dev_free callback, which is called after snd_card_disconnect(). Since device_unregister(card->card_dev) is called in snd_card_disconnect(), the whole sysfs entries belonging to card->card_dev have been already removed recursively. Thus this results in a warning as input_unregister_device() yet tries to unregister the already removed sysfs entry. For fixing this mess, we need to unregister the jack input device at dev_disconnect callback so that it's called before unregistering the card->card_dev. Reviwed-by: Mark Brown Signed-off-by: Takashi Iwai --- Reading git-diff-tree failed