From: Paul Walmsley Date: Fri, 13 Apr 2012 12:34:31 +0000 (-0600) Subject: ARM: OMAP1: board files: deduplicate and clean some NAND-related code X-Git-Tag: omap-cleanup-sparse-for-v3.5^2~1 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=31cde0447d779c1b4ae9feb51dc917d6e287de2b;p=pandora-kernel.git ARM: OMAP1: board files: deduplicate and clean some NAND-related code The H2, H3, Perseus2, and FSample board files all contain the same duplicated code to handle NAND commands. That code is missing some casts around conversions from unsigned long to void __iomem *. Consolidate the duplicated code into a new file, arch/arm/mach-omap1/board-nand.c. Resolve the sparse warnings by adding appropriate casts: arch/arm/mach-omap1/board-h2.c:193:9: warning: incorrect type in argument 1 (different base types) arch/arm/mach-omap1/board-h2.c:193:9: expected void const volatile [noderef] * arch/arm/mach-omap1/board-h2.c:193:9: got unsigned long arch/arm/mach-omap1/board-perseus2.c:157:9: warning: incorrect type in argument 1 (different base types) arch/arm/mach-omap1/board-perseus2.c:157:9: expected void const volatile [noderef] * arch/arm/mach-omap1/board-perseus2.c:157:9: got unsigned long arch/arm/mach-omap1/board-fsample.c:199:9: warning: incorrect type in argument 1 (different base types) arch/arm/mach-omap1/board-fsample.c:199:9: expected void const volatile [noderef] * arch/arm/mach-omap1/board-fsample.c:199:9: got unsigned long arch/arm/mach-omap1/board-h3.c:195:9: warning: incorrect type in argument 1 (different base types) arch/arm/mach-omap1/board-h3.c:195:9: expected void const volatile [noderef] * arch/arm/mach-omap1/board-h3.c:195:9: got unsigned long Thanks to Arnd Bergmann for suggesting a cleaner implementation of omap1_nand_cmd_ctl(), avoiding some casts. Signed-off-by: Paul Walmsley Cc: Brian Swetland Cc: Imre Deak Cc: Greg Lonnon Cc: Kevin Hilman Cc: Kevin Hilman Cc: Arnd Bergmann --- Reading git-diff-tree failed