From: James Smart Date: Fri, 8 Aug 2008 00:49:30 +0000 (-0400) Subject: [SCSI] scsi_host_lookup: error returns and NULL pointers X-Git-Tag: v2.6.28-rc1~732^2~36 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=315cb0ad124575e75da2d0e0a95990587fc23485;p=pandora-kernel.git [SCSI] scsi_host_lookup: error returns and NULL pointers This patch cleans up the behavior of scsi_host_lookup(). The original implementation attempted to use the dual role of either returning a pointer value, or a negative error code. User's needed to use IS_ERR() to check the result. Additionally, the IS_ERR() macro never checks for when a NULL pointer was returned, so a NULL pointer actually passes with a success case. Note: scsi_host_get(), used by scsi_host_lookup(), can return a NULL pointer. Talk about a mudhole for the unitiated to step into.... This patch converts scsi_host_lookup() to return either NULL or a valid pointer. The consumers were updated for the change. Signed-off-by: James Smart Signed-off-by: James Bottomley --- Reading git-diff-tree failed