From: Bert Wesarg Date: Sat, 16 Apr 2005 22:25:42 +0000 (-0700) Subject: [PATCH] kernel/param.c: don't use .max when .num is NULL in param_array_set() X-Git-Tag: v2.6.12-rc3~119 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=31143a12044caa3521edafd736e3bc18c098d2fd;p=pandora-kernel.git [PATCH] kernel/param.c: don't use .max when .num is NULL in param_array_set() there seems to be a bug, at least for me, in kernel/param.c for arrays with .num == NULL. If .num == NULL, the function param_array_set() uses &.max for the call to param_array(), wich alters the .max value to the number of arguments. The result is, you can't set more array arguments as the last time you set the parameter. example: # a module 'example' with # static int array[10] = { 0, }; # module_param_array(array, int, NULL, 0644); $ insmod example.ko array=1,2,3 $ cat /sys/module/example/parameters/array 1,2,3 $ echo "4,3,2,1" > /sys/module/example/parameters/array $ dmesg | tail -n 1 kernel: array: can take only 3 arguments Signed-off-by: Bert Wesarg Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- Reading git-diff-tree failed