From: Al Viro Date: Fri, 19 Aug 2005 21:42:16 +0000 (+0100) Subject: [PATCH] jffs2: fix symlink error handling X-Git-Tag: v2.6.13-rc7~59^2~14 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2fb1e3086df9b454538491fba8121298da37cd23;p=pandora-kernel.git [PATCH] jffs2: fix symlink error handling The current calling conventions for ->follow_link() are already fairly complex. What we have is 1) you can return -error; then you must release nameidata yourself and ->put_link() will _not_ be called. 2) you can do nd_set_link(nd, ERR_PTR(-error)) and return 0 3) you can do nd_set_link(nd, path) and return 0 4) you can return 0 (after having moved nameidata yourself) jffs2 follow_link() is broken - it has an exit where it returns -EIO and leaks nameidata. Signed-off-by: Linus Torvalds --- Reading git-diff-tree failed