From: Ming Lei Date: Wed, 17 Sep 2014 09:47:58 +0000 (+0800) Subject: blk-mq: remove unnecessary blk_clear_rq_complete() X-Git-Tag: fixes-against-v3.18-rc2~51^2~41 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2edd2c740b2918eb0a9a1fe1b69678b903769ec2;p=pandora-kernel.git blk-mq: remove unnecessary blk_clear_rq_complete() This patch removes two unnecessary blk_clear_rq_complete(), the REQ_ATOM_COMPLETE flag is cleared inside blk_mq_start_request(), so: - The blk_clear_rq_complete() in blk_flush_restore_request() needn't because the request will be freed later, and clearing it here may open a small race window with timeout. - The blk_clear_rq_complete() in blk_mq_requeue_request() isn't necessary too, even though REQ_ATOM_STARTED is cleared in __blk_mq_requeue_request(), in theory it still may cause a small race window with timeout since the two clear_bit() may be reordered. Signed-off-by: Ming Lei Signed-off-by: Jens Axboe --- Reading git-diff-tree failed