From: Javier Martinez Canillas Date: Tue, 26 Jun 2012 22:22:20 +0000 (+0200) Subject: staging: gdm72xx: fix an skb memory leak X-Git-Tag: v3.6-rc1~100^2~512 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2da049bd5f9b0dbd688519fdb6688a4895fe8395;p=pandora-kernel.git staging: gdm72xx: fix an skb memory leak The NLMSG_PUT() macro contains a hidden goto that jumps to the nlmsg_failure label. Since the sk_buff was allocated before the macro, jumping to the nlmsg_failure label leaks the memory allocated for it. Calling kfree() before returning would fix it, but is better to avoid using this error prone macro and use nlmsg_put() instead. Also, use nlmsg_data() instead of NLMSG_DATA() to check type. Signed-off-by: Javier Martinez Canillas Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed